Thomas Lin Pedersen

Results 675 comments of Thomas Lin Pedersen

Have we aligned around the idea of separating scale reversion out of the transformation completely? I think this is the correct approach as the current system is way too limited...

@karawoo do you have any knowledge about this logic? https://github.com/tidyverse/ggplot2/blob/87e9b85dd9f2a294f339d88a353d0c11c851489d/R/position-jitterdodge.R#L50-L55 Why is `group` ignored here? Sorry if this not your table but you are the "dodge-master" in my head 🙂

The only thing I can see is that group will be derived from the other aesthetics if not given explicitly which may lead to some sort of compounding in the...

I can see in the code that the outer ring gets added explicitly as a final grid line... I see two paths: 1. Make the addition user-controllable with an `add.outer.grid`...

What is the performance repercussions of searching all loaded namespaces? There are many standard aesthetics for which scales do not exist, because they are used as-is so `find_scale()` is called...

There will be one for every aesthetic not provided with an explicit scale in the plot construction... conserving this path for non-atomic aesthetics is probably a worthwhile addition... Think about...

Just a thought on your last idea. I don’t think `gradient2` is used for diverging scales as these usually have a midpoint colour, not just two extremes. I see no...

Haha - I guess I have been starring at code for too long

I’m pretty sure that was the reason. I’m all for a better way of allowing users to set a default scale

I think if we went ahead and nuked the plot_env we might as well come up with a better solution for setting scale defaults than looking for specifically named functions