Thomas Lin Pedersen comments

Results 675 comments of


                                            Thomas Lin Pedersen

`geom_sf()`: add support for `scale_x_continuous(n.breaks = )`

Thanks... My guess is it comes down to `sf`, but you never know...

Support scale functions in packages not attached via scale_type()

sure

allow `coord_fixed()` with `facet_grid(..., scales = "free", space = "free")` when x and y scales are discrete

I'm generally fine with this if it can be implemented in a clean way

key height gets stretched when using multiline key-labels or large font size in the legend

This is deliberate, though I can understand why it may be undesirable... We may consider adding a switch in the guide to control this...

"Introduction to ggplot2" vignette

yeah, I think so too... It should probably not be very long - just a brief introduction to the core API and a pointer to the book

Length of legend title affects justification of legend keys/labels?

I think this reaches beyond the currently provided theme settings... The title alignment is basically doing what it should, and so does `legend.box.just` since it aligns multiple legends with each...

Justifying the legend with respect to the full plot area rather than the panel

Agreed that this would make sense

Drop non-constant aesthetics more thoroughly

@clauswilke no problem at all, was just going through open PRs and this seemed to belong in your review bucket given the issue discussion — no stress

Drop non-constant aesthetics more thoroughly

@clauswilke will you have time for this one within the next couple of weeks? Sorry to keep pinging you — if you are floored by other work just let me...

Axes at interior panels #4064

@clauswilke any thoughts on this - I'm in two minds