Tommy Hofmann

Results 702 comments of Tommy Hofmann

No, it cannot. It is fast because it mutates the entries of the output matrix. The function works as long as you know that in your output matrix, none of...

I hope I understood it correctly. I agree that the current `one(M)` (where `M` is a matrix space) or `M(a)` constructors yield elements which cannot be used with the proposed...

Thanks @martinra for your input. Because I had to recall our reasoning behind https://github.com/Nemocas/Nemo.jl/issues/278, let me just write down some of the details here, as far as I remember. I...

While implementing things in C may help with a special case, this still does not solve the issue here. This is an issue in AbstractAlgebra, unrelated to Nemo or flint....

Hm, I have a different opinion. I don't like the dots. I don't like the superfluous `//` either, but using Nemo/Oscar, it looks much better and I don't see a...

I find ``` julia> zero_matrix(QQ, 2, 2) [. .] [. .] ``` rather obscure. To be honest, I am not too excited about this change. Maybe we could hide it...

Thanks for summing up the mismatch between the documentation and the reality. There are some other aspects of `canonical_unit` that require changes that would including fixing this. So I am...

No, this is intentional, see the discussion in https://github.com/Nemocas/AbstractAlgebra.jl/pull/692

It is documented as the first item here: http://nemocas.github.io/Nemo.jl/latest/developer/topics/#Aliasing-rules

Yes, you are constructing it (you are the "Constructor") and must ensure that the coefficients do not alias each other. We are not checking this :)