Tommy Hofmann

Results 702 comments of Tommy Hofmann

Just a random comment: Maybe `is_homogenous_standard`? Grammar is worse, but easier to discover with tabcompletion. Also, we could make `is_homogeneous(f)` for an element `f` of a non-graded polynomial ring spill...

Yes, these are base functions and base types. What do you suggest we do?

1. We should not have it in this form for the same reason we don't have linear indexing: It is ambiguous. 2. Is violates `A == matrix(A, nrows(A), ncols(A), vec(A))`...

I am happy to rename it to `_vec` in Oscar and postpone this discussion.

This is a question of definition. I am happy for someone to adjust it.

`AllParts` is a non-documented, internal, "inplace" iterator. The nonexported (don't know why) versions `partitions/partitions!` are the official functions. I guess we should have `partitions(Vector{Int}, 5)` to have a version returning...

I disagree. What is the downside of having the `roots => factor` fallback?