Tommy Hofmann
Tommy Hofmann
I don't quite follow all the reasons why something must change. But let me mention some things so that we are all on the same page. 1) There is a...
The origin of all the `:compact` business is https://github.com/Nemocas/AbstractAlgebra.jl/pull/294. I hope this makes the original intent of using `:compact` clearer. Since then, I would say we learned two things: 1....
This is back: https://github.com/Nemocas/Nemo.jl/actions/runs/8546742962/job/23417708965?pr=1700 (This downstream test run only checks Oscar.)
We went through great pains to not make orderings part of the polynomial ring and now we reintroduce it? We could have saved a lot of time and discussions.
This looks good. I will add them to AA today. The `Int/Integer` one would be ```julia AbstractAlgebra.promote_rule(::Type{gfp_mpoly}, ::Type{
But you can add them here too and we sort things out later. This should not hold up your PR.
`Oscar.promote_rule` is not what you want. It is working correctly with the correct function ``` julia> Nemo.promote_rule(FqFieldElem, Integer) FqFieldElem julia> Nemo.promote_rule(FqFieldElem, ZZRingElem) FqFieldElem ```
https://github.com/oscar-system/Oscar.jl/blob/master/src/Oscar.jl#L218-L226
I don't understand why this was not moved to experimental.
@delphinepol Once your recent PR is merged, could you make a PR to move your things from `examples` to `experimental`? That would be great, thanks.