Tommy Hofmann

Results 702 comments of Tommy Hofmann

I find my self always typing `F = free_group(["x", "y"]); x, y = gens(F)`, so I would welcome the change of the return type. But I have no strong opinion...

I think we decided against that in https://github.com/oscar-system/Oscar.jl/issues/3059#issuecomment-1836292910.

I think the problem is that there is a mismatch between names. For modules (edit: and abelian groups): - direct product = product (with projections) - direct sum = coproduct...

These three things are categorical concepts (product, coproduct and biproduct). They exist for modules and abelian gorups. But there is no mathematical biproduct for groups. I am just wondering, whether...

Is there a reason you went with more delimiters then necessary? ``` F = @fp_group( a,b,c | a^2, # relator b^2 = c, # relation a*b*c = 1, # relation...

I would suggest we first get something consistent here in OSCAR and afterwards start thinking about moving things around. The focus before 1.0 should be on a final API (which...

Let me also ping @lkastner: is there anyone in Berlin that has some input on the API question for combinatorics?

I think just returning `ZZ` respectively `QQ` is fine.

I plan to rename `matrix_algebra/MatrixAlgebra` from AbstractAlgebra to `matrix_ring`, so that `matrix_algebra` can be a matrix algebra.

I don't think we have a strong opinion on the order of the arguments. But maybe there was a specific reason @fieker? I like the idea of doing `X =...