Thibault Krebs
Thibault Krebs
Overall the PR is looking quite good for me, great job on this integration. I have added 2 comments, once reviewed we can push this PR in staging for the...
I am moving this integration in our test env. I will test it soon and keep you posted later today
@djova I was off for one week. there is an issue with another asset that is blocking me from testing it in staging, I will check internally if we can...
I have just removed the no deploy label. I will also be able to test this in our test environment later today 👍
Looks quite good for me about the logs files. I will push this in our test environment and run a test tomorrow. I will keep you posted by then!
All good for me on logs. I am approving the PR.
I rechecked the log file and it looks good for me, I have reapproved the PR 👍
@bparmar-crest I cannot test this PR in our test environment as long the PR without assets is not merged... (https://github.com/DataDog/integrations-core/pull/18204)
Looks good for me in our staging environment for logs. I am approving the PR 👍
For logs files, it is looking very good 👍, good job on this. I am pushing it in our test environment and will give you news soon for a potential...