[SIEMINT-42] [Release] DDS: Mimecast: Crawler Integration v1.0.0
What does this PR do?
This is a initial release PR of Mimecast integration including all the required assets.
Additional Notes
- Crawler code for this integration has been committed in its respective repo
- Pipeline and Facet group created for this integration are available in our sandbox and would be shared separately with the required teams.
- Samples for the pipeline review would also be shared separately with the required teams.
- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository.
- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behaviour
Review checklist (to be filled by reviewers)
- [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [ ] Changelog entries must be created for modifications to shipped code
- [ ] Add the
qa/skip-qalabel if the PR doesn't need to be tested during QA. - [ ] If you need to backport this PR to another branch, you can add the
backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged
Thanks, created DOCS-8355 to review
Overall the PR is looking quite good for me, great job on this integration. I have added 2 comments, once reviewed we can push this PR in staging for the final check!
I am moving this integration in our test env. I will test it soon and keep you posted later today
@thibaultkrebs are test in our test env ok? can we move forward with this integration today?
@djova I was off for one week. there is an issue with another asset that is blocking me from testing it in staging, I will check internally if we can unblock this PR as soon as possible.
@ravindrasojitra-crest this PR needs to be rebased. once you've done that feel free to remove the assets/no-deploy label
@ravindrasojitra-crest this PR needs to be rebased. once you've done that feel free to remove the
assets/no-deploylabel
Maybe we don't have rights to remove labels, can someone help with this please?
I have just removed the no deploy label. I will also be able to test this in our test environment later today 👍
@savandalasaniya-crest please fix the failing CI errors
@savandalasaniya-crest please fix the failing CI errors
@Wyrine this failure we are getting in every PR. We are not able to resolve it as we do not have access to add/remove labels.