integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

[SIEMINT-79] DDSaaS: LastPass: Crawler Integration v1.0.0

Open bparmar-crest opened this issue 1 year ago • 3 comments

What does this PR do?

This is a initial release PR of LastPass integration including all the required assets.

Additional Notes

  • Crawler code for this integration has been committed in its respective repo
  • Pipeline created for this integration are available in our sandbox and would be shared separately with the required teams.
  • Samples for the pipeline review would also be shared separately with the required teams. OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository.
  • Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behaviour.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

bparmar-crest avatar Aug 07 '24 06:08 bparmar-crest

Thanks, created DOCS-8656 to review

buraizu avatar Aug 07 '24 20:08 buraizu

@bparmar-crest I cannot test this PR in our test environment as long the PR without assets is not merged... (https://github.com/DataDog/integrations-core/pull/18204)

thibaultkrebs avatar Aug 16 '24 09:08 thibaultkrebs

@bparmar-crest I cannot test this PR in our test environment as long the PR without assets is not merged... (#18204)

@thibaultkrebs I have marked this PR as draft. Once No-assets PR will get merged, I change this PR as Ready for Review.

bparmar-crest avatar Aug 21 '24 06:08 bparmar-crest

image Looks good for me in our staging environment for logs. I am approving the PR 👍

thibaultkrebs avatar Sep 03 '24 09:09 thibaultkrebs