Daniel Egger comments

Results 547 comments of


                                            Daniel Egger

New static mutable storage for the entry function

Nice idea, I like it.

FYI for new warn-by-default lint `mismatched_lifetime_syntaxes`

@jieyouxu Thanks lot for following up so extensively.

Use `web-time` crate instead of unmaintained `instant` crate

Would you prefer blind feature flags or removing them from CI? > Also, is it good to always include js for wasm? Some wasm builds may not have JavaScript available....

Use `web-time` crate instead of unmaintained `instant` crate

> Well, removing them would be breaking, although we can keep an empty feature just for the sake of compatibility... I'm not hung up either way, just not break code....

Use `web-time` crate instead of unmaintained `instant` crate

I already added the flags back. The current build failure is also on `main` and comes from unpinned `ahash` pulling in the incompatible `getrandom` `0.3.3`: ``` # cargo tree --invert...

Use `web-time` crate instead of unmaintained `instant` crate

With `ahash` pinned to `0.8.4`, this PR builds just fine: ``` # cargo build --target wasm32-unknown-unknown --features wasm-bindgen Compiling rhai v1.22.2 (/Users/egger/OSS/rhai) Compiling wasm-bindgen v0.2.100 Compiling js-sys v0.3.77 Compiling getrandom...

Use `web-time` crate instead of unmaintained `instant` crate

"support" is a strong word for passing a feature flag to a dependency. Technically people could still use the `stdweb` crate which had it's last release 5 years ago but...