Daniel Egger

I don't like the idea of generic `Unused` pins in `gpio` because they're not related to GPIO. Also the use of the `Unused` pins is a bit too simple for...

> I understand why you'd want to prevent usage of every pin as Unused, not quite sure if it's that important and it seems pretty involved. I mean, it's pretty...

> Unfortunately these leds are pretty popular (at least in arduino world) and that's one of the best ways to get a somewhat sane implementation across devices, so it's probably...

> I depend on others not having too much time between writing each SPI byte, which is guranteed by having a fast enough cpu (and a somewhat sane SPI interface)....

> You also compromise regular spi usage by being able to disable Mosi and/or Miso, even though both configurations are often used, so I don't see the point. How is...

> We don't uphold our traits anymore, since we still have a FullDuplex trait, even though the input data is garbage. Eh what? If you disconnect your device the data...

> We're (the end user, technically) giving third party libraries this trait. If they update to use this trait fully (for doing lcd optimizations or whatever), functioning software may break...

@david-sawatzke There's literally no difference if the user configured the SPI incorrectly (clock speed to high, incorrect bitwidth, wrong clocking polarity/phase...) or there's a hardware problem (wires crossed, connection broken,...

> The hardware thing is the same with sck. You can also just not connect it by accident. Yes, you can always mess up. > Just because it's possible to...

> Yeah, but you shouldn't get an serial::Read trait out of a Peripheral which only has an Tx Pin safely. I agree, also ideally you wouldn't be able to use...