John Freeman

Results 86 comments of John Freeman

Where I left off: - Windows build has a runtime mismatch. Perhaps Conan 2.x requires a different way to configure MSVC runtime. Need to investigate. - `conan` test to build...

My suggestion: build both rippled and clio from source. The packages expect specific compatible versions as dependencies, but you want to use a custom version of rippled that is modified...

Ok I walked through the process and found two problems in the rippled [branch](https://github.com/mvadari/rippled/tree/d8e0cd1e6f51b6cdb91a99c4213afaaa35e968b8) you are using: 1. The Conan recipe is outdated. 2. The plugin public headers are not...

I don't see any approvals in here yet, so I say roll them into this PR.

The Windows error is this [bug](https://stackoverflow.com/questions/5134523/msvc-doesnt-expand-va-args-correctly). Below is the fix, to go in `ledger_entries.macro`: ```cpp #ifndef LEDGER_ENTRY_DUPLICATE #define EXPAND(x) x #define LEDGER_ENTRY_DUPLICATE(...) EXPAND(LEDGER_ENTRY(__VA_ARGS__)) #endif ... #undef EXPAND #undef LEDGER_ENTRY_DUPLICATE ```

Happy to help with this as I can. Will take a look this evening. Please communicate with me here if there's something you'd like to ask.