rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Switching some unit tests to doctest

Open vvysokikh1 opened this issue 9 months ago • 2 comments

High Level Overview of Change

This PR is continuation of work done by @thejohnfreeman. We intend to move from our unit tests framework to doctest.

Context of Change

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Refactor (non-breaking change that only restructures code)
  • [ ] Performance (increase or change in throughput and/or latency)
  • [x] Tests (you added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation update
  • [ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • [ ] Release

API Impact

  • [ ] Public API: New feature (new methods and/or new fields)
  • [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • [ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • [ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

vvysokikh1 avatar Apr 03 '25 15:04 vvysokikh1

Happy to help with this as I can. Will take a look this evening. Please communicate with me here if there's something you'd like to ask.

thejohnfreeman avatar Apr 03 '25 15:04 thejohnfreeman

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.1%. Comparing base (df6daf0) to head (f6fb86d). Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5383     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          817     816      -1     
  Lines        71705   71605    -100     
  Branches      8240    8240             
=========================================
- Hits         56716   56618     -98     
+ Misses       14989   14987      -2     

see 6 files with indirect coverage changes

Impacted file tree graph

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 03 '25 16:04 codecov[bot]

@vvysokikh1 can you please address the review comments & resolve the conflicts? This change would be perfect for the next release.

bthomee avatar Jun 20 '25 15:06 bthomee

@vvysokikh1 can you please address the review comments & resolve the conflicts? This change would be perfect for the next release.

Comments addressed

vvysokikh1 avatar Jun 23 '25 10:06 vvysokikh1