John Freeman

CI caught a format issue. Instructions on how to fix it are in the [job log](https://github.com/XRPLF/rippled/actions/runs/5272266930/jobs/9534301806?pr=4243).

It will be squashed when it is merged. Now that there are at least two approvals and all checks pass, you can add the "Passed" label if you think this...

Following up on an old [question](https://github.com/XRPLF/rippled/pull/4243#issuecomment-1577685372): @HowardHinnant @ckeshava please never force-push in a PR. If you end up in a situation where you don't want to bother resolving conflicts, and...

clang-format [changed formatting](https://bugs.llvm.org/show_bug.cgi?id=45992) across patch versions, so it's not as stable as you might think. I won't be able to take advantage of these images until they tag specific versions...

Sorry, I missed the earlier pings for my attention. It is not a problem to use the Boost macro. We already have to do something similar for `std::result_of`, which has...

You executed what commands? You've not included enough context to debug your situation. Please copy a full log that reproduces your error into a Gist (not a GitHub comment). `CMake.patch_config_paths`...

"Red herring" means distraction, irrelevant. I don't know why you linked that comment, or what it has to do with this issue. I can see it mentions `CMake.patch_config_paths`, but this...

I don't think we expect validators to build rippled. I think they use our packages. @legleux @manojsdoshi can you confirm? Regardless, there are other profile changes we already require and...

If you're not going to put the build instructions in this PR right now, can you please share them in a comment?

The definition of `BOOST_BEAST_USE_STD_STRING_VIEW` will need to be the same for all translation units whether the source file uses it directly or not. It is expected that the current PR...