rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Migrate to Conan 2.x

Open thejohnfreeman opened this issue 11 months ago • 6 comments

This is a draft branch for testing CI with Conan 2.x. Contributors should switch soon. Conan 1.x package recipes are now frozen. They will no longer receive updates. The project builds just fine with Conan 2.x, and we can even simplify the build instructions.

thejohnfreeman avatar Dec 11 '24 16:12 thejohnfreeman

Current state:

  • macOS works.
  • Linux: dependencies job works, but test job fails when trying to run conan --version in the check environment step.
  • Windows: takes forever. have never waited for the outcome, but appears to work.

thejohnfreeman avatar Dec 11 '24 17:12 thejohnfreeman

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.9%. Comparing base (ea1fffe) to head (53b620a). Report is 148 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5219     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          783     783             
  Lines        66677   66677             
  Branches      8108    8108             
=========================================
- Hits         51921   51918      -3     
- Misses       14756   14759      +3     

see 3 files with indirect coverage changes

Impacted file tree graph

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 11 '24 22:12 codecov[bot]

I believe this latest state will work for all checks. macOS may fail with 1 flaky error, as it has been doing for weeks. Everything else should pass.

thejohnfreeman avatar Dec 11 '24 23:12 thejohnfreeman

Where I left off:

  • Windows build has a runtime mismatch. Perhaps Conan 2.x requires a different way to configure MSVC runtime. Need to investigate.
  • conan test to build the example project that depends on xrpl is failing because Conan 2.x does not support the --require-override option.

thejohnfreeman avatar Dec 13 '24 17:12 thejohnfreeman

@thejohnfreeman

What are your current thoughts on conan v2 ?

sublimator avatar Apr 24 '25 09:04 sublimator

We're working on migrating to Conan 2 imminently.

legleux avatar Apr 29 '25 14:04 legleux

This PR has been superseded by https://github.com/XRPLF/rippled/pull/5480.

bthomee avatar Jun 24 '25 17:06 bthomee