Markus Denhoff

Results 40 comments of Markus Denhoff

Since there is no roadmap for this plug-in I can't add it. But I think this makes the plug-in a lot more flexible this will be the next feature I'm...

I’m thinking about having a hook that gets the `$oauthUser` (`ResourceOwnerInterface`) as a first parameter and the second one is the Kirby user. Then you can modify the user or...

This depends largely on your Oauth provider. I remember from a project that fetching the groups for a Google user is pretty hard to do. Have you tried to fetch...

Yes setting the options in the `ready` hook is not supported as the plugin already initialises the KirbyGit class when being loaded. But, the plugin should use the content folder...

Thanks for your pull request. I would prefer to have the second parameter of the hook require a `ResourceOwnerInterface` as this is typed and could make things more flexible (so...

Sorry for my late reply, I’ve been on vacation. > Instead of the oauthUserData you want to pass the oauthUser to provide the full ResourceOwnerInterface. This would change the first...

Thank you! I’ll check everything and maybe include this feature right into the next release.

This should be possible, at least if you have just one provider configured. And I think it’s only possible with JavaScript redirect in this screen but I really like the...

The setting needs to be included in the API route here: https://github.com/thathoff/kirby-oauth/blob/master/lib/Controller.php#L42 After this the settings are available to the LoginScreen in JavaScript here: https://github.com/thathoff/kirby-oauth/blob/master/src/components/LoginScreen.vue#L42 I would check if we...

Hi, thanks for your pull request. Did you plan to implement a hard reset to the remote branch? Currently from my point of view it just discards all uncommitted local...