kirby-git-content icon indicating copy to clipboard operation
kirby-git-content copied to clipboard

feat: add git reset button

Open dserv-nh opened this issue 1 year ago • 2 comments

Partially resolves #106

dserv-nh avatar Jun 26 '24 14:06 dserv-nh

Hi, thanks for your pull request. Did you plan to implement a hard reset to the remote branch? Currently from my point of view it just discards all uncommitted local changes (which is exactly what the “Revert Changes“ button in the “Uncommitted changes” section does.

In addition I have a couple of questions and remarks:

  • The icon seems to be broken as reset-left is not in the standard icon set of Kirby
  • The button deletes data without user confirmation it should be implemented like the other buttons with a confirmation dialog. In this case you event don’t need an API route.

thathoff avatar Jul 01 '24 20:07 thathoff

Thanks for your feedback. I didn't know about the "Revert Changes" button yet. This was just my first try and I couldn't test it. I need to set up a Kirby dev environment. As for the icon I thought I could use any icon from the Remix icons, that's why I went for reset-left Will probably update this in the coming weeks and also add more features.

dserv-nh avatar Jul 02 '24 07:07 dserv-nh