Markus Denhoff

Results 40 comments of Markus Denhoff

Ah, ok. That’s a really good reason. Do you think it’s enough to implement an IP check? For example a configuration option like `c::set('gcapc-allowed-ips', ["::1", "127.0.0.1", "1.2.3.4"]);`. This should be...

OK! I’ve just created another issue (#12) for this. I think an IP check is a good option to so I leave this issue open, too. Thanks for your input!...

Oh, that’s right! It’s `/oauth/login/PROVIDER_ID` where `PROVIDER_ID` is the key of the config option in `config.php`. We’ll definitely need to add this to the readme.

Thanks! The question is: How can we support all providers by not requiring the installation via composer. I currently don’t have a proper solution for this.

Yeah I know. But the problem is the plugin itself is basically useless without installing additionally dependencies. To use Google as an identity provider you have to manually add the...

Hmm, I like the idea of a custom plugin. But nevertheless you always need composer so I don’t see a real advantage in providing other installation methods. But we will...

Hi, yes you can set the `cronHooksSecret` [config option](https://github.com/thathoff/kirby-git-content#configuration-options). In this case the push/pull routes need an additional `secret` get parameter. I don’t know why I kept this issue open...

I can reproduce this. I’ll release an update in the next couple of days.

Hi, just published v3.1.0 containing the fix! :) Thanks for your patience…

You’re welcome! And it is a common use case indeed! I already thought about having a hook inside the `loginUser()` ([here](https://github.com/thathoff/kirby-oauth/blob/master/lib/Controller.php#L124)) method to implement custom modifications to the Kirby user...