Markus Denhoff

Results 40 comments of Markus Denhoff

The problem is that we sometimes run into a race condition where Kirby triggers an update/sorted hook when things have not changed or have already been committed. Thats one of...

Can you try to open the browser’s console and check if you get a bit more information about this error? The file and line number where this happens would be...

Thanks! This helps a lot to trace down this bug.

Unfortunately I’m not able to reproduce this. Can you please replace line 134 in `src/KirbyGitHelper.php` which should be `throw new Exception('Unable to update git: ' . $exception->getMessage());` with `throw $exception;`...

That helps. Thank you. We’re also evaluating switching back to the original version of the git library we’re using (See #83), so this might be fixing it. But I’m still...

This is fixed by switching to the new git library in v5.0.0

Thanks, that’s a very good question. I think we had in issue with the original version so we used the fork. We definitely should evaluate a switch back to kbjr/Git.

I think the only problem are the composer dependencies, right? I’ll have a look how other plugins handle this.

Thanks, this looks like very good idea for me...

Hey! We actually thought about this but decided to go without authentication because the hooks don’t disclose any information and it should be totally safe to call them externally. The...