Nick Terrell

Results 153 comments of Nick Terrell

Thanks for the PR @medns, and sorry for the delay! This looks good to me!

Thanks for the extremely detailed reports @dweiller! I'll go through each case and respond to them individually, though I may not find the time until later this week.

@MarcusCalhoun-Lopez we're preparing a new release and I've attempted to fix this issue in #4222. Please let me know if this fixes your issue. It looks like this PR is...

Adding this issue to track our plans for API evolution. Mainly moving functions to stable, or deprecating & deleting old functions. Marked as `release-blocking` so we don't forget about it...

As @Cyan4973 mentioned, Zstd is dual licensed under GPLv2 and BSD 3-clause. Zstd is **not** licensed under GPLv2+, but choosing the BSD license may be preferable for you, if you...

This breaks decompression. I don't understand the goal of this PR. Can you explain what you are trying to accomplish?

@ryandesign I've attempted to fix this in PR #4222, please let me know if this fixes your issue. Thanks for the PR & the time you spent debugging this issue!...

Please re-open if the issue persists after #4222.

I think there could be a small improvement to the heuristic. The blocks found are a single match. with 0 literals.

That looks like it is just a bad test. If you change it to invoke zstd with a single parameter like `--parameter-does-not-exist`, I think the test will pass (because the...