Nick Terrell
Nick Terrell
Actually, this block used to be invalid. Older versions of the spec had this clause: > A Compressed_Block has the extra restriction that Block_Size is always strictly less than the...
This frame is the simplest test case. The only difference from the one you provided is that yours has the `Unused_Bit` of the frame header set to 1. ``` 28b5...
The one liner fix is to change `MIN_CBLOCK_SIZE` from `3` to `2`. However, that definitely breaks some bounds checks in `ZSTD_decodeLiteralsBlock()`, and maybe elsewhere. So more care is needed.
See https://github.com/facebook/zstd/pull/3092 for the decompressor errata document.
@klauspost `MIN_CBLOCK_SIZE` isn't supposed to be including the block header (at least in the way it is used in the literals section decoding). In this case the block size is...
Whats the difference between the C version and the ASM version? It looks like the gains for the aarch64 version are smaller than the gains for the x86-64 version, which...
Is the C version the current zstd code, or the fast decode C you've written? If it is the latter, what is the difference between zstd's code and the tuned...
Can you try removing the cmake build directory and rebuilding?
To clarify, the build is still working, just emitting this warning message, correct? We'll still want to fix it either way.
We can't default to window sizes larger than 8MB, because that is the max window size we say all decoders should support in our spec. So you must explicitly opt...