facebook
1.5.7: test suite fails in zstd / valgrindTest
Describe the bug Test suite fails in valgrind test.
To Reproduce Steps to reproduce the behavior:
- build with
%meson \
-D backtrace=disabled \
-D bin_contrib=true \
-D bin_programs=true \
-D bin_tests=true \
-D debug_level=0 \
-D lz4=disabled \
-D lzma=disabled \
-D multi_thread=enabled \
-D static_runtime=false \
-D zlib=disabled \
%{nil}
Expected behavior Test suite should not fail.
Screenshots and charts
Test suite execution output
```==563325== HEAP SUMMARY:
==563325== in use at exit: 0 bytes in 0 blocks
==563325== total heap usage: 1 allocs, 1 frees, 4,096 bytes allocated
==563325==
==563325== All heap blocks were freed -- no leaks are possible
==563325==
==563325== For lists of detected and suppressed errors, rerun with: -s
==563325== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
==565097== Memcheck, a memory error detector
==565097== Copyright (C) 2002-2024, and GNU GPL'd, by Julian Seward et al.
==565097== Using Valgrind-3.24.0 and LibVEX; rerun with -h for copyright info
==565097== Command: programs/zstd
==565097==
==565097==
==565097== HEAP SUMMARY:
==565097== in use at exit: 0 bytes in 0 blocks
==565097== total heap usage: 63 allocs, 63 frees, 2,928,026 bytes allocated
==565097==
==565097== All heap blocks were freed -- no leaks are possible
==565097==
==565097== For lists of detected and suppressed errors, rerun with: -s
==565097== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
Traceback (most recent call last):
File "/home/tkloczko/rpmbuild/BUILD/zstd-1.5.7/build/meson/tests/valgrindTest.py", line 90, in
5/10 zstd:fast / test-zstd-fast OK 16.46s 6/10 zstd / test-fullbench-2 OK 22.48s 7/10 zstd / test-fullbench-1 OK 27.75s 8/10 zstd / test-decodecorpus OK 30.01s 9/10 zstd / test-zstream-3 OK 90.07s 10/10 zstd / test-zstream-1 OK 94.54s
Summary of Failures:
4/10 zstd / valgrindTest FAIL 6.16s exit status 1
Ok: 9 Expected Fail: 0 Fail: 1 Unexpected Pass: 0 Skipped: 0 Timeout: 0
</details>
**Desktop (please complete the following information):**
- OS: Linux
- Version [e.g. 22]
- Compiler gcc
- Flags:
<details>
<summary>List of all build flags injected over env variables to build env</summary>
$ rpm --eval "%set_build_flags"
ASMFLAGS="-m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -O2 -g -grecord-gcc-switches -pipe -mtls-dialect=gnu2 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdata-sections -ffunction-sections -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -flto=auto -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -Wall -Werror=format-security"; CFLAGS="-m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -O2 -g -grecord-gcc-switches -pipe -mtls-dialect=gnu2 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdata-sections -ffunction-sections -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -flto=auto -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -Wall -Werror=format-security"; CXXFLAGS="-m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -O2 -g -grecord-gcc-switches -pipe -mtls-dialect=gnu2 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdata-sections -ffunction-sections -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -flto=auto -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -Wall -Werror=format-security"; FFLAGS="-m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -O2 -g -grecord-gcc-switches -pipe -mtls-dialect=gnu2 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdata-sections -ffunction-sections -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -flto=auto -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -Wall -Werror=format-security -I/usr/lib64/gfortran/modules"; FCFLAGS="-m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -O2 -g -grecord-gcc-switches -pipe -mtls-dialect=gnu2 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdata-sections -ffunction-sections -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -flto=auto -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -Wall -Werror=format-security -I/usr/lib64/gfortran/modules"; LDFLAGS="-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--gc-sections -Wl,--as-needed -Wl,--build-id=sha1 -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,-z,pack-relative-relocs -flto=auto -fuse-linker-plugin"; RUSTFLAGS="-C codegen-units=1 -C debuginfo=2 -C opt-level=2 -C link-arg=-Wl,--as-needed -C link-arg=-Wl,--build-id=sha1 -C link-arg=-Wl,-z,now -C link-arg=-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -C link-arg=-Wl,-z,pack-relative-relocs -C link-arg=-Wl,-z,relro -C link-arg=-flto=auto --cap-lints=warn" ; VALAFLAGS="-g" ; CC="/usr/bin/gcc"; CXX="/usr/bin/g++"; FC="/usr/bin/gfortran"; AR="/usr/bin/gcc-ar"; NM="/usr/bin/gcc-nm"; RANLIB="/usr/bin/gcc-ranlib"; export ASMFLAGS CFLAGS CXXFLAGS FFLAGS FCFLAGS LDFLAGS VALAFLAGS CC CXX FC AR NM RANLIB RUSTFLAGS VALAFLAGS;
</details>
- Other relevant hardware specs: none
- Build system: Linux x86/64
**Additional context**
None
That looks like it is just a bad test. If you change it to invoke zstd with a single parameter like --parameter-does-not-exist, I think the test will pass (because the command will fail).
