Nick Terrell
Nick Terrell
If you can reproduce it, could you run your program under TSAN, ASAN, and MSAN? That will help rule out unrelated issues like 2 cctx's being used by different threads...
@uilianries Zstd should not require the public include directory to build, because it uses relative includes. Is this a deficiency in the Windows cmake build, or have I misunderstood something...
I'm happy to accept the PR, I would just like to understand why this is happening first
> Then, it requires zstd.h (the public header) too: Thanks! I didn't even realize that that file existed! We've switched all of our other headers over to relative includes. Would...
https://github.com/facebook/zstd/pull/3998 works around the issue for clang >= 16, but we still need a fix for older clang versions. Honestly, we could just drop support for CpuId for older clang...
> I am OK with dropping older clangs support. To be clear, everything would still work, just older compilers wouldn't get opted into code gated by checking the CPUID. So...
Agreed, this would be a desirable behavior
> Will honest raise verion of subsystem/operation system up to 6.0? I'm not quite sure I understand. Are you saying that `zstd.exe` is advertising it works with older Windows versions,...
`HUF_DISABLE_FAST_DECODE` does this, it is documented in `lib/decompress/README.md`
`--patch-from` does already using rolling hashes! However, we also use our regular match finders, so end up inserting the whole file anyway. One idea would be to only insert the...