zstd icon indicating copy to clipboard operation
zstd copied to clipboard

Published 20 hours ago • verified publisher icon facebook

v1.5.6 breaks 32-bit Windows clang-cl build

Open terrelln opened this issue 1 year ago • 3 comments

See https://github.com/facebook/zstd/commit/94c102038b81ed89e3b013cb1977496612609f85

Reported-by: @georgthegreat

terrelln avatar Apr 01 '24 16:04 terrelln

https://github.com/facebook/zstd/pull/3998 works around the issue for clang >= 16, but we still need a fix for older clang versions.

Honestly, we could just drop support for CpuId for older clang versions on Windows, and just return that nothing is supported.

terrelln avatar Apr 01 '24 16:04 terrelln

I am OK with dropping older clangs support.

I do not know what chrome and firefox are using, however.

georgthegreat avatar Apr 01 '24 17:04 georgthegreat

I am OK with dropping older clangs support.

To be clear, everything would still work, just older compilers wouldn't get opted into code gated by checking the CPUID. So only perf would be impacted.

terrelln avatar Apr 01 '24 20:04 terrelln