Max Klein

Results 127 comments of Max Klein

`allowed_envs` sounds pretty good. The thing is, the client env_whitelist option doesn't just allow or whitelist a set of vars, it actively forwards them (or at least tries to) from...

Getting even more ambitious, it would also be nice if said `forward_env` options were able to forward vars all the way to the environment of the kernel itself. I think...

Those names sound reasonable. I'll start working on this. > perhaps we could make the "user values" be built dynamically pyyaml is good and flexible, so I think this is...

ooo, and speaking of pyyaml, it looks like a `pyyaml` requirement should get added to `setup.py` and `requirements.yml`. Although the `launch_kubernetes.py` script technically isn't part of the `enterprise_gateway` python pkg...

@kevin-bates Sorry for the delay, work on this is now underway over at #1000

> I think `kernel_inherited_envs` and `kernel_forwarded_envs` denote their intention more clearly (IMO). @kevin-bates I agree those are a bit more expressive. I was also thinking about maybe `forward_envs_server_to_kernel` and `forward_envs_gateway_to_kernel`,...

## 'Fun' with CRDs! I also looked into replacing `launch_kubernetes.py` and the ever-confusing `kernel-pod.yaml.j2` with a single `kernel` custom resource description (CRD). Prior to this I didn't know anything about...

Hey @kevin-bates, thanks for the detailed response. > I suppose we could add a _disallowed_ list such that envs in that list will NOT be propagated to the kernel, yet...

@kevin-bates Looking back over your kernel parameterization JEP, I see that the Plan C I suggested is basically the same as your proposal for [parameterized environment variables](https://github.com/jupyter/enhancement-proposals/blob/4c0727fbe03653aba789de67c388e2d28cda4cb9/parameterized-launch/parameterized-launch.md#environment-variables), only without the...

Related, out of all the handler methods in jeg, why are the ones in kernelspecs the only ones wrapped in `web.authenticated`: https://github.com/jupyter/enterprise_gateway/blob/b760823caf19743fe5f278615e99067f15e9694d/enterprise_gateway/services/kernelspecs/handlers.py#L63-L64 ?