Max Klein

Results 127 comments of Max Klein

I've done some testing of the PR code and everything appears to be working as advertised: - [ComfyUI-KJNodes](https://github.com/kijai/ComfyUI-KJNodes) is a good example of an existing extension that has complex custom...

This PR is now out of draft status, is more-or-less feature complete, and is ready for testing. Especially if you have a windows machine, please checkout this PR branch and...

Overall LGTM! Just one small nit with emitting a warning instead of failing silently on pypi request timeout/failure

Before I proceed further on this, I'd like to get as much feedback (and hopefully buy-in) as I can. @echarles @vidartf @jtpio Are icons that you can consume like CSS...

What's weird is that the ~~command bar~~ toolbar that sits below the tab bar seems to know if a kernel is busy: idle: ![image](https://user-images.githubusercontent.com/2263641/43745941-639b9c0e-99af-11e8-8aa4-3f5dc99fa63a.png) busy: ![image](https://user-images.githubusercontent.com/2263641/43745643-eac7cc2c-99ad-11e8-89cf-28d366a3079c.png) So I guess it...

One complication is that the tabs use a similar filled circle symbol to indicate unsaved changes in a file: ![image](https://user-images.githubusercontent.com/2263641/43745872-14000bc6-99af-11e8-97a8-4c77c603b89f.png) This is actually pretty confusing (originally I thought it meant...

I ran into @andrii-i at jupytercon and he asked me to weigh in on the issue. > I think visual hierarchy argument makes a lot of sense, have not considered...