Max Klein

Results 127 comments of Max Klein

I'm able to see part of the problem by calling `.setDataListener(..., {virtual_mode: "vertical"})` directly in the console after my grid has already loaded normally: ![image](https://user-images.githubusercontent.com/2263641/112998106-b7f02a00-913b-11eb-8b9a-15e20fc19adf.png) So it looks like somehow...

> I'll note that a data model that returns rows "outside" of its data bounds isn't really correct @texodus That sounds right. Yeah, I have previously noticed cases where `end_col`...

finally had a sec to play around with this. Previously [my code](https://github.com/telamonian/tree-finder/blob/26ed16d3d7559a582af7d2186d5ab85eac90f12a/packages/tree-finder/src/element/grid.ts#L73-L105) was iterating over a range of col indices: ``` for (let cix = start_col; cix < end_col -...

@texodus Another way to look at it is that the wobbliness of `end_col` has been a built-in feature since day one, in the service of better flexibility and overall performance....

Multicolumn sort now tree-aware: ![image](https://user-images.githubusercontent.com/2263641/83570705-83e4b200-a4f4-11ea-87bb-8572fce3d407.png) ~Got a bit messy, but is fully functional. I'll try and clean it up~ Cleanup done. Tree-aware multisort implementation still significantly more complex than multisort...

I added sorting tests to `file_browser.test.js`. The tests for sorting a flat filebrowser all pass. The tests for sorting a filebrowser tree with several expanded nodes work in principle, but...

Absolutely. My plan for this is to add a breadcrumbs/filter UI component to the top of the filename column. Think along the lines of github's "find file" UI: ![github_file_search_ui](https://user-images.githubusercontent.com/2263641/84058708-96913800-a987-11ea-9603-752ae249ddda.gif)

> Too much more granular and you'll never be able to scroll to the end. I agree that there's an inherent contradiction here someplace. At the same time, whether I'm...

I've been getting bit by a similar bug lately while working with "fancy" `th` column headers that contain several children in a vertical layout. So it seems like bug will...

@texodus Had asked me for a repro of this issue a while back. So here's a simple repro that shows how having a "fat" row in the column header breaks...