Max Klein

Results 127 comments of Max Klein

@timkpaine `tree-finder` is in need of a styling pass and some kind of theming system (ie a way for external pkgs like jupyter-fs to supply colors and other key style...

I'm not fully convinced that any of these do everything a jupyter contents layer needs, and I assume they all do a lot of stuff we don't need. I think...

I've been talking to @martindurant about `fsspec` for a while now (he's the creator). My current preference is to not throw the baby out with the pyfilesystem bathwater, and instead...

The current design goal is that `navigateToCurrentDirectory` will first switch to the correct browser before attempting to navigate to a directory. Will that satisfy your use case?

pinging @jtpio @blink1073. ~~If anyone can give me explicit instructions on how to test these changes as part of eg `pip install -e ./jupyterlab`, that would be super helpful~~ nm,...

> So, if you're able, do you think you'd be able to rebase this onto https://github.com/joerick/pyinstrument/pull/203? Probably. Two questions: - what's the likely eta for #203 getting pulled into main?...

> #203 is now merged, so you can rebase onto main instead. Awesome! Thank you @joerick for getting that pulled in so quickly. That should make things quite a bit...

closing in favor of #217

up to 42/63 checks passing as of 4388e02. Woo!

> Needs another rebase from #10796 that's gonna happen a lot. Both `package.json` and `yarn.lock` underwent large scale formatting changes, so any other PR that touches either of those is...