Till Knuesting

NOffsprings has to higher than 0

3

The unsigned int mod.NOffsprings can be never negative hence here is a logic bug. ``` if mod.NOffsprings

Logging

1

How would I log when somebody does send a request with a bad token?

Is there a good example how to integrate the zap logging interceptor?

I would like to only generate code related to unmarshalling of a data type as I would not use the marshalling bits. Is there a flag or do I need...

drop this Else and outdent its block

1

Makes it more readable

code review

2

I did some code review with help of static analysis and refactored some parts.

Error return value is not checked

5

``` message.go:935:21: Error return value of `bs.Envelope.Parse` is not checked bs.Envelope.Parse(envelope) ``` ``` message.go:939:26: Error return value of `bs.BodyStructure.Parse` is not checked bs.BodyStructure.Parse(structure) ``` ``` read.go:218:14: Error return value of...

unnecessary conversion

6

``` response.go:125:35: unnecessary conversion (unconvert) fields := []interface{}{RawString(tag)} ``` ``` read.go:82:38: unnecessary conversion (unconvert) nbr, err := strconv.ParseUint(string(s), 10, 32) ``` ``` status.go:97:49: unnecessary conversion (unconvert) if err := w.writeFields([]interface{}{RawString(tag),...

Use non cryptographic hash for unique ID instead of MD5

10

I would like to discuss to replace md5 with a non cryptographic hash function like xxhash or murmur3 as they are much faster. For example we use md5 to generate...

Anybody running this in Kubernetes and can give instructions how to do this?