go-imap
go-imap copied to clipboard
unnecessary conversion
response.go:125:35: unnecessary conversion (unconvert)
fields := []interface{}{RawString(tag)}
read.go:82:38: unnecessary conversion (unconvert)
nbr, err := strconv.ParseUint(string(s), 10, 32)
status.go:97:49: unnecessary conversion (unconvert)
if err := w.writeFields([]interface{}{RawString(tag), RawString(r.Type)}); err != nil {
response.go:125:35: unnecessary conversion (unconvert) fields := []interface{}{RawString(tag)} status.go:97:49: unnecessary conversion (unconvert) if err := w.writeFields([]interface{}{RawString(tag), RawString(r.Type)}); err != nil {
False positives, the type is checked by writeFields (RawString vs string).
@tegk, creating a lot of issues like this without even reading the code isn't really helpful. Please consider sending a single pull request with commits fixing the issues instead.
@tegk, creating a lot of issues like this without even reading the code isn't really helpful. Please consider sending a single pull request with commits fixing the issues instead.
I did read the code. Some can be matter of opinion so its worth discussing beforehand. Will try my best to send a pull request. Sorry, I did not intend to upset you!
Some can be matter of opinion so its worth discussing beforehand.
One issue would have been enough :P
Will try my best to send a pull request. Sorry, I did not intend to upset you!
Thanks!
One issue would have been enough :P
Thanks, I will keep this in mind. The issues are not related to each other from a technical perspective thus seemed the right way to do it.
The issues are not related to each other from a technical perspective thus seemed the right way to do it.
Consider this:
- It feels like spam
- It's just the raw dump from the linter without any added value
- It's minor issues
I appreciate the enthusiasm, but still!