code review

[tegk]

I did some code review with help of static analysis and refactored some parts.

[codecov[bot]]

Codecov Report

Merging #303 into master will increase coverage by 0.02%. The diff coverage is 79.56%.

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   73.05%   73.07%   +0.02%     
==========================================
  Files          32       32              
  Lines        3462     3465       +3     
==========================================
+ Hits         2529     2532       +3     
  Misses        641      641              
  Partials      292      292

Impacted Files	Coverage Δ
server/cmd_noauth.go	73.84% <ø> (ø)	:arrow_up:
client/cmd_noauth.go	67.05% <ø> (ø)	:arrow_up:
client/cmd_any.go	57.89% <ø> (ø)	:arrow_up:
client/cmd_auth.go	63.07% <ø> (ø)	:arrow_up:
client/client.go	62.69% <ø> (ø)	:arrow_up:
status.go	34.78% <0%> (ø)	:arrow_up:
imap.go	0% <0%> (ø)	:arrow_up:
read.go	91.42% <100%> (ø)	:arrow_up:
server/conn.go	72.58% <100%> (ø)	:arrow_up:
seqset.go	97.2% <100%> (+0.01%)	:arrow_up:
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7aeb464...ec3dcd8. Read the comment docs.

[foxcpp]

This PR can be a candidate for merge in v2.

[emersion]

Closing because this is superseded by go-imap v2.