ConfX
ConfX
Thanks, @ZanderXu, for the review. I researched if the XORRawDecoder can decode multiple erased indexes, and I found that XORRawDecoder can generate only 1 parity bit, implying the erased indexes...
Thank you for replying @ZanderXu. We completely agree with your reasoning that no UTs will use negative data. But since the other input parameter (chunkSizeKB) to the method is [handled...
@Apache9 Thank you for your feedback! By an "umbrella issue", do you prefer a GitHub issue or a JIRA ticket?
@Apache9 Thanks! We opened the umbrella issue in Jira: https://issues.apache.org/jira/browse/HBASE-28104
@Apache9 Sorry for the late reply. I added the value in the error message.
HBASE-27989. ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking
@Apache9 I pushed a new checking logic for both zero and negative value.
> ok, i'm going to add one more change, and this time we do go near that production code. how about logging a warning in the FileOutputCommitter constructor at Line...
I have changed the name of the PR and the Issue accordingly. Thanks for the response!
Hi @goiri is there anything else I can do to make this PR merged?