hbase icon indicating copy to clipboard operation
hbase copied to clipboard

HBASE-27993. AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking

Open teamconfx opened this issue 2 years ago • 10 comments

teamconfx avatar Sep 11 '23 16:09 teamconfx

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 55s master passed
+1 :green_heart: compile 2m 26s master passed
+1 :green_heart: checkstyle 0m 34s master passed
+1 :green_heart: spotless 0m 42s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 26s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 29s the patch passed
+1 :green_heart: compile 2m 26s the patch passed
+1 :green_heart: javac 2m 26s the patch passed
+1 :green_heart: checkstyle 0m 34s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 9m 32s Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 :green_heart: spotless 0m 41s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 32s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 9s The patch does not generate ASF License warnings.
31m 52s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5390
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 45554bd467d1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 97d512be7c
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 11 '23 16:09 Apache-HBase

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 30s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 48s master passed
+1 :green_heart: compile 0m 49s master passed
+1 :green_heart: shadedjars 4m 37s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 27s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 31s the patch passed
+1 :green_heart: compile 0m 46s the patch passed
+1 :green_heart: javac 0m 46s the patch passed
+1 :green_heart: shadedjars 4m 36s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 25s the patch passed
_ Other Tests _
-1 :x: unit 225m 38s hbase-server in the patch failed.
247m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5390
Optional Tests javac javadoc unit shadedjars compile
uname Linux bd784d170898 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 97d512be7c
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/1/testReport/
Max. process+thread count 4449 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 11 '23 20:09 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 35s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 13s master passed
+1 :green_heart: compile 0m 57s master passed
+1 :green_heart: shadedjars 5m 33s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 27s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 9s the patch passed
+1 :green_heart: compile 0m 52s the patch passed
+1 :green_heart: javac 0m 52s the patch passed
+1 :green_heart: shadedjars 5m 44s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 24s the patch passed
_ Other Tests _
+1 :green_heart: unit 230m 0s hbase-server in the patch passed.
255m 36s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5390
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0254ae85b3e8 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 97d512be7c
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/1/testReport/
Max. process+thread count 4365 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Sep 11 '23 20:09 Apache-HBase

Thanks for providing lots of PRs to make HBase more robust.

Could you please open an umbrella issue first, and then convert all the related issues as sub tasks of this big issue, so it is easier to track these issues?

Apache9 avatar Sep 15 '23 01:09 Apache9

@Apache9 Thank you for your feedback! By an "umbrella issue", do you prefer a GitHub issue or a JIRA ticket?

teamconfx avatar Sep 16 '23 16:09 teamconfx

A jira ticket please. HBase uses jira for tracking issues.

Thanks.

Apache9 avatar Sep 17 '23 08:09 Apache9

@Apache9 Thanks! We opened the umbrella issue in Jira: https://issues.apache.org/jira/browse/HBASE-28104

teamconfx avatar Sep 21 '23 01:09 teamconfx

Good. Thanks for the effort. Will take a look at these patches soon.

Apache9 avatar Sep 21 '23 02:09 Apache9

Any updates here? @teamconfx

Thanks.

Apache9 avatar Oct 06 '23 12:10 Apache9

Ping @teamconfx

Apache9 avatar Oct 24 '23 06:10 Apache9

@Apache9 Sorry for the late reply. I added the value in the error message.

teamconfx avatar Mar 20 '24 21:03 teamconfx

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 3m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 3s master passed
+1 :green_heart: compile 2m 31s master passed
+1 :green_heart: checkstyle 0m 36s master passed
+1 :green_heart: spotless 0m 44s branch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 32s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 47s the patch passed
+1 :green_heart: compile 2m 30s the patch passed
+1 :green_heart: javac 2m 30s the patch passed
+1 :green_heart: checkstyle 0m 35s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: hadoopcheck 4m 56s Patch does not cause any errors with Hadoop 3.3.6.
+1 :green_heart: spotless 0m 43s patch has no errors when running spotless:check.
+1 :green_heart: spotbugs 1m 39s the patch passed
_ Other Tests _
+1 :green_heart: asflicense 0m 12s The patch does not generate ASF License warnings.
31m 16s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5390
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 1d968721f6b0 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0763a74096
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 20 '24 22:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 27s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 3m 11s master passed
+1 :green_heart: compile 0m 52s master passed
+1 :green_heart: shadedjars 5m 30s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 26s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 43s the patch passed
+1 :green_heart: compile 0m 51s the patch passed
+1 :green_heart: javac 0m 51s the patch passed
+1 :green_heart: shadedjars 5m 27s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 24s the patch passed
_ Other Tests _
+1 :green_heart: unit 204m 33s hbase-server in the patch passed.
229m 10s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5390
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0cbb135ae981 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0763a74096
Default Java Eclipse Adoptium-17.0.10+7
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/testReport/
Max. process+thread count 5062 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 21 '24 01:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 24s Docker mode activated.
-0 :warning: yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 2m 43s master passed
+1 :green_heart: compile 0m 39s master passed
+1 :green_heart: shadedjars 5m 38s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 23s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 2m 25s the patch passed
+1 :green_heart: compile 0m 39s the patch passed
+1 :green_heart: javac 0m 39s the patch passed
+1 :green_heart: shadedjars 6m 6s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 27s the patch passed
_ Other Tests _
+1 :green_heart: unit 228m 42s hbase-server in the patch passed.
252m 3s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5390
Optional Tests javac javadoc unit shadedjars compile
uname Linux 2a61cafb5be8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0763a74096
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/testReport/
Max. process+thread count 4406 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 21 '24 02:03 Apache-HBase

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 5m 3s Docker mode activated.
-0 :warning: yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 :green_heart: mvninstall 4m 40s master passed
+1 :green_heart: compile 1m 11s master passed
+1 :green_heart: shadedjars 6m 31s branch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 39s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 55s the patch passed
+1 :green_heart: compile 1m 2s the patch passed
+1 :green_heart: javac 1m 2s the patch passed
+1 :green_heart: shadedjars 5m 59s patch has no errors when building our shaded downstream artifacts.
+1 :green_heart: javadoc 0m 26s the patch passed
_ Other Tests _
+1 :green_heart: unit 235m 2s hbase-server in the patch passed.
269m 26s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR https://github.com/apache/hbase/pull/5390
Optional Tests javac javadoc unit shadedjars compile
uname Linux cb3e767158fb 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0763a74096
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/testReport/
Max. process+thread count 4929 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5390/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase avatar Mar 21 '24 02:03 Apache-HBase