MAPREDUCE-7448. Inconsistent Behavior for FileOutputCommitter V1 to commit successfully many times

[teamconfx]

Description of PR

https://issues.apache.org/jira/browse/MAPREDUCE-7448

This PR adds a documentation change to warn the user about the issue as suggested.

For code changes:

• [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[hadoop-yetus]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+0 :ok:	markdownlint	0m 0s		markdownlint was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 :green_heart:	mvninstall	34m 44s		trunk passed
+1 :green_heart:	mvnsite	0m 34s		trunk passed
+1 :green_heart:	shadedclient	57m 15s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	0m 25s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	mvnsite	0m 27s		the patch passed
+1 :green_heart:	shadedclient	27m 22s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 29s		The patch does not generate ASF License warnings.
		90m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6038/1/artifact/out/Dockerfile
GITHUB PR	https://github.com/apache/hadoop/pull/6038
Optional Tests	dupname asflicense mvnsite codespell detsecrets markdownlint
uname	Linux cc6860143ecf 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 74ccab5348357559c963a54be1e5fcbcd8c368a3
Max. process+thread count	709 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6038/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[steveloughran]

ok, i'm going to add one more change, and this time we do go near that production code. how about logging a warning in the FileOutputCommitter constructor at Line 160?

if (algorithmVersion == 1 && skipCleanup) { LOG.warn(""); }

[teamconfx]

ok, i'm going to add one more change, and this time we do go near that production code. how about logging a warning in the FileOutputCommitter constructor at Line 160?

I've made the change accordingly with an extensive warning message.

[hadoop-yetus]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+0 :ok:	markdownlint	0m 0s		markdownlint was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
-1 :x:	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 :green_heart:	mvninstall	31m 52s		trunk passed
+1 :green_heart:	compile	0m 33s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 :green_heart:	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 :green_heart:	checkstyle	0m 30s		trunk passed
+1 :green_heart:	mvnsite	0m 35s		trunk passed
+1 :green_heart:	javadoc	0m 29s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 :green_heart:	javadoc	0m 23s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 :green_heart:	spotbugs	1m 1s		trunk passed
+1 :green_heart:	shadedclient	21m 17s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	0m 24s		the patch passed
+1 :green_heart:	compile	0m 25s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 :green_heart:	javac	0m 25s		the patch passed
+1 :green_heart:	compile	0m 22s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 :green_heart:	javac	0m 22s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
-0 :warning:	checkstyle	0m 20s	/results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt	hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 2 new + 15 unchanged - 0 fixed = 17 total (was 15)
+1 :green_heart:	mvnsite	0m 26s		the patch passed
+1 :green_heart:	javadoc	0m 17s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 :green_heart:	javadoc	0m 16s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 :green_heart:	spotbugs	0m 55s		the patch passed
+1 :green_heart:	shadedclient	21m 3s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 :green_heart:	unit	5m 59s		hadoop-mapreduce-client-core in the patch passed.
+1 :green_heart:	asflicense	0m 29s		The patch does not generate ASF License warnings.
		91m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6038/2/artifact/out/Dockerfile
GITHUB PR	https://github.com/apache/hadoop/pull/6038
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint
uname	Linux 5d216b36b949 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 2fed9f54a62758019f517c25af799f0e94e6a16c
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6038/2/testReport/
Max. process+thread count	1347 (vs. ulimit of 5500)
modules	C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6038/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.