Tobias Grieger
Tobias Grieger
> I might even be willing to argue that changing address/port demands a membership change. There might still be an argument for that, at least if addresses aren't going to...
> I am currently working on a release in my fork that will get merged upstream with 1-2 weeks. Could we use the upstream repo with a replace directive in...
in #81 (which adds a `DisableConfChangeValidation` option), @pavelkalinnikov says: ---- I think we should fix this lag in `raft` more fundamentally, in such a way that the `DisableConfChangeValidation` option is...
Unfortunately, the official protobuf library lacks an equivalent to `(gogoproto.nullable)`. We have a number of non-primitive fields that would then be turned into pointers, which would likely negatively impair the...
I assume this will be fixed when https://github.com/google/pprof/issues/477 is.
Just confirming that this was not fixed by https://github.com/google/pprof/pull/924, which came out of #477. refresh after `rm` the binary:
I take it back - had updated the pprof binary incorrectly. Thank you @alk!
Sad to report that it still doesn't always work. I hit another blank page when navigating to source, which rendered only after removing the binary referenced in the profile.
Closing this PR: I'll be opening a new prototype PR off https://github.com/cockroachdb/cockroach/pull/149511 (once that has merged) with a flattened commit history, which should be easier to evolve. Since this PR...