cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

mma: prototype

Open sumeerbhola opened this issue 10 months ago • 6 comments

Informs #103320

Epic: CRDB-25222

Release note: None

sumeerbhola avatar Feb 28 '25 16:02 sumeerbhola

This change is Reviewable

cockroach-teamcity avatar Feb 28 '25 16:02 cockroach-teamcity

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Mar 04 '25 01:03 blathers-crl[bot]

Rebased to resolve conflicts.

kvoli avatar Mar 04 '25 01:03 kvoli

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Mar 04 '25 14:03 blathers-crl[bot]

Fixed up the last commit to resolve shadowing a var.

kvoli avatar Mar 04 '25 20:03 kvoli

Rebased on master to pick up https://github.com/cockroachdb/cockroach/commit/607b5e57b9aeaf08bdfe12c73084886287615f98 - more in https://cockroachlabs.slack.com/archives/CJ0H8Q97C/p1743531027447729. (I show up as a co-author for everything as a result, but I didn't contribute anything 😬)

wenyihu6 avatar Apr 02 '25 13:04 wenyihu6

Rebased again on master - some of the rebase were not very trivial (especially when resolving conflicts with 21b454c6a7cc6386d4bd643e2a6daaa3165e5422 and https://github.com/cockroachdb/cockroach/blob/e1648f8c8b0db7facd4f2f27a7bb6ce71c010f10/pkg/kv/kvserver/asim/state/impl.go#L1161-L1174).

wenyihu6 avatar Jun 19 '25 03:06 wenyihu6

Closing this PR: I'll be opening a new prototype PR off https://github.com/cockroachdb/cockroach/pull/149511 (once that has merged) with a flattened commit history, which should be easier to evolve. Since this PR is referenced in the doc comments for the mmaprototype package in #149511, let's keep this PR unmodified from here on out.

tbg avatar Jul 04 '25 11:07 tbg