Tobias Grieger

Results 53 comments of Tobias Grieger

Agreed with @ahrtr. It's useful to make a mental distinction between "known committed" and "actually committed". An entry is committed if it is durable on a quorum of followers. But...

same for `peer_connected`: `server::tests::test_invalid_peer_message`: ``` thread 'server::tests::test_invalid_peer_message' panicked at 'assertion failed: peer_connected(&server, peer_id)', src/server.rs:742 ``` Unfortunately calling this "flaky" is currently an understatement. I'm hoping that's just on my machine,...

Yeah, `capnp-nonblock` is probably where this should live in the end. For now, this is already super condensed, though: ``` let mut stream = TcpStream::connect(&addr).unwrap(); stream.write(b"foo bar baz").unwrap(); ``` and...

wouldn't that just swallow the real error of not being able to connect? In that case I would expect to get `57` back indefinitely. Curious what the mio guys will...

:+1:. Are you pushing a new version & updating this crate?

works like a charm (and by that I mean, it's back to the expected flakiness).

I think it's also worth outlining adding a member from the perspective of the new member. A Raft instance must respond to anyone trying to talk to it, and there...

Possibly related issue: Was unable to post this gist here via `gist`: https://gist.github.com/tschottdorf/3913a87b72061b2f6f65 ``` bash 10:28 $ gist crashers/4ad21e7dcd127e00f23a5f46ab9736ee8af53f71.output Error: Got Net::HTTPBadRequest from gist: {"message":"Problems parsing JSON","documentation_url":"https://developer.github.com/v3"} ```

Sorry, just checked the file. Posting the file from the online gist actually works. I suppose submitting it manually through the web interface cleaned up its encoding. There are some...

These serial numbers can be implemented by the client, and do not need to be part of actual Raft (simply encode your ID into your payload), so there's no technical...