Tobias Grieger

Hmm, having trouble showing the benefit of this change. I thought that if I disabled range splits and ran a kv0 workload against the range, alongside a change that adds...

@pav-kv it's annoying that I wasn't able to demonstrate the benefit of the change. I still think semantically, this makes sense and would give us a more trustworthy. Let's discuss...

@pav-kv PTAL. I added a proper unit test, so I don't have to figure out why I wasn't able to trigger the self-blocking in the end-to-end test setup.

After ruling out a bit flip (`1` and `-1` don't look similar when varint encoded), looking through the writes to that field, there is [/pkg/kv/kvclient/rangecache/range_cache.go#L1324-L1330](https://github.com/cockroachdb/cockroach/blob/7512f81be1591cde8e3b5d34bb0b9b1101f22d24/pkg/kv/kvclient/rangecache/range_cache.go#L1324-L1330) ```go func (e *cacheEntry) toRangeInfo()...

On second thought, it's even stranger. The test asserts that there is a cache hit: [/pkg/ccl/multiregionccl/roundtrips_test.go#L126-L127](https://github.com/cockroachdb/cockroach/blob/9c21c2e9b4d0d883df9285f3f3a846510cdc023b/pkg/ccl/multiregionccl/roundtrips_test.go#L126-L127) ```go entry, err := cache.TestingGetCached(context.Background(), tablePrefix, false /* inverted */) require.NoError(t, err) ``` because...

What _should_ happen is that the kvserver returns a new RangeInfo containing the closedts policy: [/pkg/kv/kvserver/replica_send.go#L319-L330](https://github.com/cockroachdb/cockroach/blob/9c21c2e9b4d0d883df9285f3f3a846510cdc023b/pkg/kv/kvserver/replica_send.go#L319-L330) ```go // Compare the client's info with the replica's info to detect if the...

Removing `release-blocker` because this is not a new bug.

``` run_131337.075895949_n1-7_echo-0-sudo-blockdev: 13:13:37 cluster.go:2164: > echo "0 $(sudo blockdev --getsz /dev/sdb) linear /dev/sdb 0" | sudo dmsetup create data1 teamcity-16608098-1724564397-78-n7cpu2:[1 2 3 4 5 6 7]: echo "0 $(sudo blockdev...

@itsbilal [here](https://teamcity.cockroachdb.com/repository/download/Cockroach_Nightlies_RoachtestNightlyGceBazel/16608098:id/failover/non-system/disk-stall/run_1/artifacts.zip!/run_131337.429907611_n1-7_sudo-bash-c-ps-aux-d.log) is the file created by [/pkg/cmd/roachtest/roachtestutil/disk_stall.go#L200](https://github.com/cockroachdb/cockroach/blob/b0599de51ef9f9b877d47a51e4f8302aeabd99d8/pkg/cmd/roachtest/roachtestutil/disk_stall.go#L200) ```go s.c.Run(ctx, option.WithNodes(s.c.All()), "sudo bash -c 'ps aux; dmsetup status; mount; lsof'") s.f.Fatal(err) ``` And the device is `/dev/sdb 253:0` ``` run_131337.075895949_n1-7_echo-0-sudo-blockdev:...

Closing in favor of https://github.com/cockroachdb/cockroach/pull/149661.