Trevor Sodorff comments

Results 34 comments of


                                            Trevor Sodorff

Update WM.yaml

validator errors

Remove `apparentpower` and `reactivepower`

@charbull @berkoben review this.

Remove `apparentpower` and `reactivepower`

@charbull @berkoben review this

Update smart AHU

validator errors

Lighting and HVAC Entity Types

@bsaxpi rename PR -- no project related naming allowed.

update hvac abstract .yaml

validator errors

Update FCU.yaml

validator errors

Brightness is a measurement not a measurement descriptor

@pisuke for `saturation` and `brightness`, what would the units be? We can open a PR and fix this, but we will also need to see if this breaks anything that...

Abstract_update_AHU_Trip_status

fix validator errors. if github does not run them automatically, you can still run them locally. ensure your PR is valid before review, otherwise it will inhibit feedback.

Tpkd day2 new telemetry name

@Terry-Ter please see my comments regarding the different fields that look unnecessary. Can you please provide an update?