digitalbuildings icon indicating copy to clipboard operation
digitalbuildings copied to clipboard

Remove `apparentpower` and `reactivepower`

Open tasodorff opened this issue 2 years ago • 6 comments

There is already precedent for apparent and reactive power where apparent and reactive are measurement_descriptor subfields. Removing these two subfields since they deviate from precedent, and the current precedent is technically correct (since power can be measured in volt-amps already); therefore it should be kept.

tasodorff avatar Apr 28 '22 18:04 tasodorff

@charbull what's the latest with this one? still waiting for Keith's review?

mschulze17 avatar May 17 '22 18:05 mschulze17

@charbull @berkoben review this.

tasodorff avatar May 19 '22 14:05 tasodorff

@charbull @berkoben review this

tasodorff avatar Jun 01 '22 16:06 tasodorff

@charbull friendly ping

mschulze17 avatar Jun 13 '22 18:06 mschulze17

please wait for @rniemo-g review

charbull avatar Jul 07 '22 15:07 charbull

Is this good to go @tasodorff ? Or do you need Keith's approval, as well?

cstirdivant avatar Jul 14 '22 20:07 cstirdivant