digitalbuildings icon indicating copy to clipboard operation
digitalbuildings copied to clipboard

Brightness is a measurement not a measurement descriptor

Open pisuke opened this issue 3 years ago • 6 comments

@tasodorff @charbull I think brightness should be moved to measurement and not be a measurement descriptor. Thoughts? Thanks, F

pisuke avatar Jul 26 '21 17:07 pisuke

Also "saturation" should be a measurement and not a measurement description.

pisuke avatar Jul 26 '21 17:07 pisuke

@pisuke can you send a pull request please?

charbull avatar Oct 01 '21 15:10 charbull

@pisuke for saturation and brightness, what would the units be?

We can open a PR and fix this, but we will also need to see if this breaks anything that has already been defined in Carson.

tasodorff avatar Feb 15 '22 00:02 tasodorff

@pisuke @tasodorff any updates on this? @mschulze17 fyi

charbull avatar Nov 07 '22 15:11 charbull

@pisuke can you send a pull request please?

I'd be happy to contribute and open a pull request.

Is it just moving line: https://github.com/google/digitalbuildings/blob/17cd918512f052c5f4815292cda7246e50d08ac0/ontology/yaml/resources/subfields/subfields.yaml#L199 and line: https://github.com/google/digitalbuildings/blob/17cd918512f052c5f4815292cda7246e50d08ac0/ontology/yaml/resources/subfields/subfields.yaml#L219

to the measurement section?

abe-101 avatar Dec 19 '22 16:12 abe-101

@cstirdivant @tasodorff ptal

charbull avatar Jan 03 '23 15:01 charbull