node icon indicating copy to clipboard operation
node copied to clipboard

doc: split supported platforms table

Open mmarchini opened this issue 4 years ago • 6 comments

cc @nodejs/build

I reorganized the table this way because personally I found the previous version confusing, especially if you're interested in knowing what are all the platforms on a specific tier. I'm not super invested in this, so if folks think restructuring is a bad idea I'm happy to drop. Note that the tiers don't change, it's just a different way of visualizing it.


Split supported platforms table, grouping platforms by support tier. It was harder to know what are all platforms in a given tier on the previous table, this reorganization should make it easier.

Checklist
  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

mmarchini avatar Sep 16 '20 05:09 mmarchini

I reeeeeally should start running the linter locally on doc-only changes 😅

mmarchini avatar Sep 16 '20 06:09 mmarchini

Can you rebase please? The new linter version reports a few errors:

BUILDING.md
   105:73  warning  Cell should be padded with 1 space, not 3  table-cell-padding          remark-lint
   107:73  warning  Cell should be padded with 1 space, not 3  table-cell-padding          remark-lint
    145:1  warning  Remove 1 line before node                  no-consecutive-blank-lines  remark-lint
   167:39  warning  Cell should be padded with 1 space, not 4  table-cell-padding          remark-lint
   169:73  warning  Cell should be padded with 1 space, not 2  table-cell-padding          remark-lint
  173:135  warning  Cell should be padded with 1 space, not 5  table-cell-padding          remark-lint

aduh95 avatar Nov 08 '20 11:11 aduh95

ping @mmarchini

targos avatar Dec 21 '20 14:12 targos

ping @mmarchini - need a rebase to resolve git conflicts and to resolve lint issues.

PoojaDurgad avatar Jan 21 '21 08:01 PoojaDurgad

@nodejs/build do we still want to do this change? Assuming this is the case, it would be great if someone was able to take over this PR.

aduh95 avatar Sep 18 '23 08:09 aduh95

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

github-actions[bot] avatar May 05 '24 21:05 github-actions[bot]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

github-actions[bot] avatar Jun 12 '24 00:06 github-actions[bot]