Michaël Zasso

Results 1686 comments of Michaël Zasso

This is another PR that should have been labeled semver-minor.

@StefanStojanovic I've kept https://github.com/nodejs/node/pull/48456/commits/63589e5ed0a6a1dedbb1dae1a0dd7a9f97325ae5. Can you point me to the V8 CL that would make it obsolete?

Thanks, I updated the PR to cherry-pick that last commit instead of the floating patch.

Failure in shared lib build: ``` 12:29:30 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/v8_zlib/deps/v8/third_party/zlib/cpu_features.o:(.bss.x86_cpu_enable_avx512+0x0): multiple definition of `x86_cpu_enable_avx512' 12:29:30 /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/zlib/deps/zlib/cpu_features.o:(.bss+0x0): first defined here 12:29:30 collect2: error: ld returned 1 exit status 12:29:30 libnode.target.mk:546: recipe for target...

I don't see what's special about `x86_cpu_enable_avx512`. It's defined the same way as, for example, `x86_cpu_enable_simd`, which isn't causing any issues. /cc @nodejs/cpp-reviewers

> [5258be6](https://github.com/nodejs/node/commit/5258be63b30d7ec2cf31b0bd323b1ebb8d751b45) can be dropped due to upstream bug has been fixed. Upstream bug was closed, but a fix needs to happen on the Node.js side. See https://github.com/nodejs/node/issues/47297 and https://github.com/nodejs/node/pull/47452

https://github.com/nodejs/node/pull/48710

Can you try with a full run instead of a rebuild?

> > * Deleted an `eslint` text file in order to make `lint-js` command work again. `lint-js` execution would look at that file, throw a Syntax Error that `onFatalError` in...

I tried to run `./node` compiled on Fedora 38 with default configure options and it didn't fail.