Michaël Zasso

Results 1686 comments of Michaël Zasso

I'd really like to see this land. It's making it difficult to backport other changes.

I'm on the test machine to investigate. The test is actually flaky. It fails ~5% of the runs

It segfaults: ``` $ NODE_TEST_MODE=verify NODE_TEST_FIXTURE=/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/person.jpg.gz out/Release/node --snapshot-blob=/home/iojs/tmp/.tmp.6/snapshot.blob test/fixtures/snapshot/decompress-gzip-sync.js Segmentation fault (core dumped) ``` I'm installing gdb to get a stack trace.

Here's the full stack trace: ``` (gdb) bt #0 0x000055cd8d06a589 in v8::internal::Deserializer::PostProcessNewJSReceiver(v8::internal::Map, v8::internal::Handle, v8::internal::JSReceiver, v8::internal::InstanceType, v8::internal::SnapshotSpace) () #1 0x000055cd8d06aaa1 in v8::internal::Deserializer::PostProcessNewObject(v8::internal::Handle, v8::internal::Handle, v8::internal::SnapshotSpace) () #2 0x000055cd8d06dd77 in v8::internal::Deserializer::ReadObject(v8::internal::SnapshotSpace) () #3...

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/5653/

@joyeecheung (or anyone else) want to review that latest state?

Landed in 5f852cc9fe10...23069c34b261

I see a lot of `[-Wambiguous-reversed-operator]` in ICU. For example: ``` [308/3813] CXX obj/deps/icu-small/source/i18n/icui18n.pluralranges.o In file included from ../../deps/icu-small/source/i18n/pluralranges.cpp:18: In file included from ../../deps/icu-small/source/i18n/numrange_impl.h:15: In file included from ../../deps/icu-small/source/i18n/number_formatimpl.h:14: ../../deps/icu-small/source/i18n/number_utils.h:53:17:...