node icon indicating copy to clipboard operation
node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

stream: fix premature pipeline end

Open ronag opened this issue 1 year ago • 11 comments

Fixes: https://github.com/nodejs/node/issues/48406

ronag avatar Jun 12 '23 13:06 ronag

Review requested:

  • [ ] @nodejs/streams

nodejs-github-bot avatar Jun 12 '23 13:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52226/

nodejs-github-bot avatar Jun 12 '23 16:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52228/

nodejs-github-bot avatar Jun 12 '23 16:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52230/

nodejs-github-bot avatar Jun 12 '23 16:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52233/

nodejs-github-bot avatar Jun 13 '23 06:06 nodejs-github-bot

@nodejs/build it seems we can't build on ARM.

mcollina avatar Jun 13 '23 08:06 mcollina

Can you try with a full run instead of a rebuild?

targos avatar Jun 13 '23 08:06 targos

CI: https://ci.nodejs.org/job/node-test-pull-request/52235/

nodejs-github-bot avatar Jun 13 '23 09:06 nodejs-github-bot

Commit Queue failed
- Loading data for nodejs/node/pull/48435
✔  Done loading data for nodejs/node/pull/48435
----------------------------------- PR info ------------------------------------
Title      stream: fix premature pipeline end (#48435)
Author     Robert Nagy  (@ronag)
Branch     ronag:issue-48406 -> nodejs:main
Labels     stream, author ready, needs-ci
Commits    1
 - stream: fix premature pipeline end
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/48435
Fixes: https://github.com/nodejs/node/issues/48406
Reviewed-By: Matteo Collina 
Reviewed-By: Marco Ippolito 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48435
Fixes: https://github.com/nodejs/node/issues/48406
Reviewed-By: Matteo Collina 
Reviewed-By: Marco Ippolito 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 12 Jun 2023 13:17:11 GMT
   ✔  Approvals: 4
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48435#pullrequestreview-1474986414
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475174694
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475278074
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475471197
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-06-13T09:28:07Z: https://ci.nodejs.org/job/node-test-pull-request/52235/
- Querying data for job/node-test-pull-request/52235/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5277325882

nodejs-github-bot avatar Jun 15 '23 09:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52332/

nodejs-github-bot avatar Jun 21 '23 19:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52402/

nodejs-github-bot avatar Jun 23 '23 17:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/52415/

nodejs-github-bot avatar Jun 24 '23 06:06 nodejs-github-bot

Landed in cebbc57ed26ce1a572e6fe416b700ac8f6258869

nodejs-github-bot avatar Jun 24 '23 07:06 nodejs-github-bot