node icon indicating copy to clipboard operation
node copied to clipboard

build: add a flag v8_enable_simulator

Open luyahan opened this issue 1 year ago • 29 comments

The v8 simulator can help we run test for non-x64 backend on x64 machine. So I add a flag to build v8 smulator.

luyahan avatar Nov 10 '23 12:11 luyahan

Review requested:

  • [ ] @nodejs/gyp
  • [ ] @nodejs/v8-update

nodejs-github-bot avatar Nov 10 '23 12:11 nodejs-github-bot

Hi @targos Could you have time to review this pr?

luyahan avatar Nov 14 '23 08:11 luyahan

I don't feel qualified to review these changes, sorry.

targos avatar Nov 14 '23 09:11 targos

Hi @bnoordhuis
Could you have time to review this pr?

luyahan avatar Nov 15 '23 02:11 luyahan

Hi @mhdawson Could you have time to review this pr?

luyahan avatar Nov 16 '23 06:11 luyahan

I was able to get riscv64 simulator compiling, but a lot of the other configurations don't work (e.x. for cross-compilation or other reasons).

There's also a lot of configuration in the BUILD.gn which isn't replicated in this PR, for example:

  • https://source.chromium.org/chromium/chromium/src/+/main:v8/BUILD.gn;l=1281?q=target_is_simulator%20path:v8%20path:BUILD%20&ss=chromium%2Fchromium%2Fsrc
  • https://source.chromium.org/chromium/chromium/src/+/main:v8/BUILD.gn;l=2398?q=path:BUILD%20simulator%20%20path:v8%20&ss=chromium%2Fchromium%2Fsrc&start=1

Is there a reason that configuration isn't replicated in this PR?

Do you mean like this : ./configure --cross-compiling --dest-cpu=arm64?

luyahan avatar Nov 16 '23 09:11 luyahan

CI: https://ci.nodejs.org/job/node-test-pull-request/55699/

nodejs-github-bot avatar Nov 17 '23 06:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5672/

nodejs-github-bot avatar Nov 17 '23 06:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5672/

nodejs-github-bot avatar Nov 17 '23 06:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5672/

nodejs-github-bot avatar Nov 17 '23 06:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/55721/

nodejs-github-bot avatar Nov 17 '23 19:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/55846/

nodejs-github-bot avatar Nov 22 '23 01:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/55847/

nodejs-github-bot avatar Nov 22 '23 05:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/55857/

nodejs-github-bot avatar Nov 22 '23 18:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56003/

nodejs-github-bot avatar Nov 29 '23 10:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5692/

nodejs-github-bot avatar Nov 29 '23 10:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5692/

nodejs-github-bot avatar Nov 29 '23 10:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5692/

nodejs-github-bot avatar Nov 29 '23 10:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/56120/

nodejs-github-bot avatar Dec 06 '23 02:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5703/

nodejs-github-bot avatar Dec 06 '23 02:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5703/

nodejs-github-bot avatar Dec 06 '23 02:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5703/

nodejs-github-bot avatar Dec 06 '23 02:12 nodejs-github-bot

Hi I can't finad reason for node-test-commit failed. What i can do?

luyahan avatar Dec 18 '23 10:12 luyahan

CI: https://ci.nodejs.org/job/node-test-pull-request/56548/

nodejs-github-bot avatar Dec 27 '23 06:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57027/

nodejs-github-bot avatar Feb 02 '24 17:02 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5796/

nodejs-github-bot avatar Feb 02 '24 17:02 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5796/

nodejs-github-bot avatar Feb 02 '24 17:02 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5796/

nodejs-github-bot avatar Feb 02 '24 17:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57034/

nodejs-github-bot avatar Feb 03 '24 03:02 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/57737/

nodejs-github-bot avatar Mar 13 '24 21:03 nodejs-github-bot