node
node copied to clipboard
build: add a flag v8_enable_simulator
The v8 simulator can help we run test for non-x64 backend on x64 machine. So I add a flag to build v8 smulator.
Review requested:
- [ ] @nodejs/gyp
- [ ] @nodejs/v8-update
Hi @targos Could you have time to review this pr?
I don't feel qualified to review these changes, sorry.
Hi @bnoordhuis
Could you have time to review this pr?
Hi @mhdawson Could you have time to review this pr?
I was able to get riscv64 simulator compiling, but a lot of the other configurations don't work (e.x. for cross-compilation or other reasons).
There's also a lot of configuration in the BUILD.gn which isn't replicated in this PR, for example:
- https://source.chromium.org/chromium/chromium/src/+/main:v8/BUILD.gn;l=1281?q=target_is_simulator%20path:v8%20path:BUILD%20&ss=chromium%2Fchromium%2Fsrc
- https://source.chromium.org/chromium/chromium/src/+/main:v8/BUILD.gn;l=2398?q=path:BUILD%20simulator%20%20path:v8%20&ss=chromium%2Fchromium%2Fsrc&start=1
Is there a reason that configuration isn't replicated in this PR?
Do you mean like this : ./configure --cross-compiling --dest-cpu=arm64?
CI: https://ci.nodejs.org/job/node-test-pull-request/55699/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5672/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5672/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5672/
CI: https://ci.nodejs.org/job/node-test-pull-request/55721/
CI: https://ci.nodejs.org/job/node-test-pull-request/55846/
CI: https://ci.nodejs.org/job/node-test-pull-request/55847/
CI: https://ci.nodejs.org/job/node-test-pull-request/55857/
CI: https://ci.nodejs.org/job/node-test-pull-request/56003/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5692/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5692/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5692/
CI: https://ci.nodejs.org/job/node-test-pull-request/56120/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5703/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5703/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5703/
Hi I can't finad reason for node-test-commit failed. What i can do?
CI: https://ci.nodejs.org/job/node-test-pull-request/56548/
CI: https://ci.nodejs.org/job/node-test-pull-request/57027/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5796/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5796/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5796/
CI: https://ci.nodejs.org/job/node-test-pull-request/57034/
CI: https://ci.nodejs.org/job/node-test-pull-request/57737/