node
node copied to clipboard
nodejs
[v18.x] backport Ada v2.x to Node.js v18
Fixes https://github.com/nodejs/node/issues/48343 Fixes https://github.com/nodejs/node/issues/48117
Backports
- https://github.com/nodejs/node/pull/46884
- https://github.com/nodejs/node/pull/47001
- https://github.com/nodejs/node/pull/47035
- https://github.com/nodejs/node/pull/46904
- https://github.com/nodejs/node/pull/47339
- https://github.com/nodejs/node/pull/47598
- https://github.com/nodejs/node/pull/47678
- https://github.com/nodejs/node/pull/47737
- https://github.com/nodejs/node/pull/47886
- https://github.com/nodejs/node/pull/47893
- https://github.com/nodejs/node/pull/47922
- https://github.com/nodejs/node/pull/47547
I didn't include URL.canParse in this backport. I don't know the policy regards semver-minor backports. @KhafraDev can you follow up after this pull request?
@nodejs/build Appreciate it if you could review & merge this since it is a really big backport.
@nodejs/build Appreciate it if you could review & merge this since it is a really big backport.
Wrong team. Releases are managed by the release WG and LTS in particular by @nodejs/lts. FWIW https://github.com/nodejs/node/pull/48036, https://github.com/nodejs/node/pull/48092 and https://github.com/nodejs/node/pull/48223 have yet to go out in a current release. We usually do not consider things being backported to a LTS release line until it has been in a current release for two weeks.
node-test-pull-request ci: https://ci.nodejs.org/job/node-test-pull-request/52413/
@richardlau I believe this PR is finally ready to review & merge. It took a while, and became my biggest back-port ever. I've re-added Ada 2.5.0 pull request, since it is included in the latest release which got released 2-3 weeks ago.
@anonrig Would you mind an amend in commit message in 2c34b15c25f9f2c5e427b4743f547e548805503c, there is something from the rebase merge conflicts there
The diff in https://github.com/nodejs/node/commit/f2651a0812ec2f7eb0c29f20669bd942e2e47258 doesn't look right.
Only wpt/url is updated. We shouldn't see that many changes in test/fixtures/wpt/README.md and test/fixtures/wpt/versions.json
See original commit: https://github.com/nodejs/node/commit/f2651a0812ec2f7eb0c29f20669bd942e2e47258
The diff in f2651a0 doesn't look right.
Only
wpt/urlis updated. We shouldn't see that many changes intest/fixtures/wpt/README.mdandtest/fixtures/wpt/versions.jsonSee original commit: f2651a0
@targos Probably, there is another commit before this commit that updates web-platform tests, but since it is not back-ported with this pull request, we see these changes. Should I try to find that commit to update web-platform tests?
It should help to cherry pick these two first: https://github.com/nodejs/node/commit/f652f7baa6a59f0ec79b21668332c2c825d7b4d8 https://github.com/nodejs/node/commit/843856ead771a2db21d63f65eb1d52ddb264d9dd
@nodejs/build-infra Just curious; at least this PR and https://github.com/nodejs/node/pull/48275 reports the exact same failures with Windows see https://github.com/nodejs/node/pull/48275#issuecomment-1581356301, is there any chance that infra is broken for the v18.x branch?
@nodejs/build-infra Just curious; at least this PR and #48275 reports the exact same failures with Windows see #48275 (comment), is there any chance that infra is broken for the v18.x branch?
There were two PRs recently dealing with flaky tests on Windows, which landed as the following commits https://github.com/nodejs/node/commit/c6e7e4273392fa9ebf01019bf78adf84b0537cfd and https://github.com/nodejs/node/commit/c308054aaad182fbc37f3e4eef0b78efeb7d332a. I do not see them in either the v18.x-staging or the v16.x-staging branch.
