Michaël Zasso

Results 1686 comments of Michaël Zasso

> Upload the release binaries and docs to the dist-staging bucket as soon as they're uploaded to the DO server I suggest doing this between the "upload to DO" and...

> Give each releaser their own S3 api token to write to the staging bucket (unless we want this step to happen from the DO server as well) It will...

``` 2025-01-26T01:34:15.7687105Z /usr/bin/ld: /home/runner/work/node/node/node/out/Release/obj.target/nghttp3/deps/ngtcp2/nghttp3/lib/nghttp3_http.o: in function `nghttp3_http_parse_priority': 2025-01-26T01:34:15.7690793Z nghttp3_http.c:(.text+0x3c): undefined reference to `sfparse_parser_init' 2025-01-26T01:34:15.7692931Z /usr/bin/ld: nghttp3_http.c:(.text+0x5a): undefined reference to `sfparse_parser_dict' 2025-01-26T01:34:15.7703124Z /usr/bin/ld: /home/runner/work/node/node/node/out/Release/obj.target/nghttp3/deps/ngtcp2/nghttp3/lib/nghttp3_http.o: in function `nghttp3_pri_parse_priority_versioned': 2025-01-26T01:34:15.7704513Z nghttp3_http.c:(.text+0x132): undefined reference...

This seems to only happen with `conhost.exe`.

https://github.com/nghttp2/nghttp2/pull/2287

Are there platforms that we support and don't have Clang ?

With https://github.com/nodejs/node/pull/59048, we will require Clang >=19.

So we can start experimenting, here is a PR to install Clang on the Fedora-based CI hosts: https://github.com/nodejs/build/pull/4116

Not sure it's related but I saw in the logs from the Fedora/Debian machines that it's using something from GCC automatically. For example: https://ci.nodejs.org/view/All/job/targos-node-test-commit-linux/4/nodes=fedora-latest-x64/consoleFull ``` 11:38:48 ../deps/v8/src/wasm/wasm-code-manager.h:746:17: warning: 'atomic_load' is...