Michaël Zasso comments

Results 1686 comments of


                                            Michaël Zasso

V8 13.0 Deprecations

@ronag FastApiTypedArray has just been removed from upstream: https://chromium-review.googlesource.com/c/v8/v8/+/5982984

V8 13.0 Deprecations

IIUC we should use this instead: https://chromium-review.googlesource.com/c/v8/v8/+/5915615

Deadlock at process shutdown

Full diff is https://patch-diff.githubusercontent.com/raw/nodejs/node/pull/47452.diff

src: migrate `String::Value` to `String::ValueView`

PR is being reverted because of https://github.com/nodejs/node/issues/55826

tools: update clang-format to v19

FWIW I still have an experimental repo that builds `clang-format` on GitHub actions in my computer (I deleted it from GitHub when the wasm-based tool landed), if you want to...

tools: update clang-format to v19

https://github.com/targos/clang-format With test build: https://github.com/targos/clang-format/actions/runs/11124135962

tools: update clang-format to v19

So you took my idea and work to your own repository and are now suggesting to transfer that to Node.js. Not nice...

make fetch compatible with Object.freeze(globalThis)

The value returned by `Symbol.for` is not unique to the file. It will be the same in all instances of the package.

module: add `findPackageJSON` util

What about `text`? It's already used in many places of the docs.

src: parse dotenv with the rest of the options

If it fixes a lot of things, shouldn't it add a lot of tests?