node icon indicating copy to clipboard operation
node copied to clipboard

deps: update nghttp3 to 1.10.1

Open nodejs-github-bot opened this issue 11 months ago • 5 comments

This is an automated update of nghttp3 to 1.10.1.

nodejs-github-bot avatar Dec 22 '24 00:12 nodejs-github-bot

Review requested:

  • [ ] @nodejs/security-wg

nodejs-github-bot avatar Dec 22 '24 00:12 nodejs-github-bot

Wait, it seems this version requires patching as some symbols aren't being linked correctly.

RafaelGSS avatar Jan 26 '25 23:01 RafaelGSS

2025-01-26T01:34:15.7687105Z /usr/bin/ld: /home/runner/work/node/node/node/out/Release/obj.target/nghttp3/deps/ngtcp2/nghttp3/lib/nghttp3_http.o: in function `nghttp3_http_parse_priority':
2025-01-26T01:34:15.7690793Z nghttp3_http.c:(.text+0x3c): undefined reference to `sfparse_parser_init'
2025-01-26T01:34:15.7692931Z /usr/bin/ld: nghttp3_http.c:(.text+0x5a): undefined reference to `sfparse_parser_dict'
2025-01-26T01:34:15.7703124Z /usr/bin/ld: /home/runner/work/node/node/node/out/Release/obj.target/nghttp3/deps/ngtcp2/nghttp3/lib/nghttp3_http.o: in function `nghttp3_pri_parse_priority_versioned':
2025-01-26T01:34:15.7704513Z nghttp3_http.c:(.text+0x132): undefined reference to `sfparse_parser_init'
2025-01-26T01:34:15.7705318Z /usr/bin/ld: nghttp3_http.c:(.text+0x14a): undefined reference to `sfparse_parser_dict'
2025-01-26T01:34:16.3763265Z /usr/bin/ld: /home/runner/work/node/node/node/out/Release/obj.target/nghttp3/deps/ngtcp2/nghttp3/lib/nghttp3_http.o: in function `nghttp3_http_parse_priority':
2025-01-26T01:34:16.3764773Z nghttp3_http.c:(.text+0x3c): undefined reference to `sfparse_parser_init'
2025-01-26T01:34:16.3765654Z /usr/bin/ld: nghttp3_http.c:(.text+0x5a): undefined reference to `sfparse_parser_dict'
2025-01-26T01:34:16.3767172Z /usr/bin/ld: /home/runner/work/node/node/node/out/Release/obj.target/nghttp3/deps/ngtcp2/nghttp3/lib/nghttp3_http.o: in function `nghttp3_pri_parse_priority_versioned':
2025-01-26T01:34:16.3768646Z nghttp3_http.c:(.text+0x132): undefined reference to `sfparse_parser_init'
2025-01-26T01:34:16.3769472Z /usr/bin/ld: nghttp3_http.c:(.text+0x14a): undefined reference to `sfparse_parser_dict'
2025-01-26T01:34:16.8948937Z clang++: error: linker command failed with exit code 1 (use -v to see invocation)
2025-01-26T01:34:16.8992169Z make[2]: *** [cctest.target.mk:354: /home/runner/work/node/node/node/out/Release/cctest] Error 1
2025-01-26T01:34:16.8993696Z make[2]: *** Waiting for unfinished jobs....
2025-01-26T01:34:17.1519596Z clang++: error: linker command failed with exit code 1 (use -v to see invocation)
2025-01-26T01:34:17.1555014Z make[2]: *** [embedtest.target.mk:312: /home/runner/work/node/node/node/out/Release/embedtest] Error 1
2025-01-26T01:34:18.0096596Z rm 8c172c245075c22cfbd0b4982ce5452e8c890687.intermediate d567cc7bfa368e8372691deb815cb082aa225f95.intermediate c9ad195c230c21da8c09325739d93789c150ea07.intermediate 8818a687bcd71f4d195e33ad9a6b5cf087ba2923.intermediate
2025-01-26T01:34:18.0105437Z make[1]: *** [Makefile:135: node] Error 2

sfparse is explicitly excluded here: https://github.com/nodejs/node/blob/adf8e97401bb3f1bb0b9a7e7c20f163deac301a2/deps/ngtcp2/ngtcp2.gyp#L84-L85

targos avatar Jan 29 '25 09:01 targos

Leave this one please. I'll be doing another round of quic/http3 updates next month and will update the dependencies at that time.

jasnell avatar Jan 29 '25 15:01 jasnell

Please do not merge this yet.

jasnell avatar May 07 '25 00:05 jasnell